WIP: refactor cul menu: runtime json, bundling, cache #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
er-k
commented
Jan 16, 2026
er-k
commented
- added runtime json fetching for menus with remote/local fallback.
- split vertical (collapse) and navbar menu renderers into separate modules.
- introduced cul-menu bundle (iife + es) for external site usage.
- added cache-busting, graceful loading, and mark-loaded css classes.
- updated vite config for separate bundle build and proper outdir.
- made menu renderer less opinionated with data-attribute overrides.
- ensured backwards-compatible handlebars fallbacks.
- fixed slug & special character issues in menu ids for safe selectors.
- added runtime json fetching for menus with remote/local fallback. - split vertical (collapse) and navbar menu renderers into separate modules. - introduced cul-menu bundle (iife + es) for external site usage. - added cache-busting, graceful loading, and mark-loaded css classes. - updated vite config for separate bundle build and proper outdir. - made menu renderer less opinionated with data-attribute overrides. - ensured backwards-compatible handlebars fallbacks. - fixed slug & special character issues in menu ids for safe selectors.
- refactored menu rendering to fetch menu json at runtime - support for authoritative remote menu via VITE_CUL_MENU_URL - environment configuration - graceful fallback to bundled example json on fetch failure - cache-busting using app version - loading state handling for menu containers - cleanup. updated cul-main-menu.json with current menu items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.