ci(capi): use TRANSCRIBE_HIP instead of GGML_HIP for ROCm jobs - #3
Merged
Conversation
Upstream PR handy-computer#121 (223c9b0) added a TRANSCRIBE_HIP option that wraps GGML_HIP via FORCE, plus a PIC fix guarded by TRANSCRIBE_HIP for the hipcc/ROCm static-archive link problem. Passing -DGGML_HIP=ON directly left that PIC fix disabled — the ROCm jobs only worked because BUILD_SHARED_LIBS=ON happened to turn PIC on via ggml. Switch the Linux and Windows ROCm-CPU configure steps to -DTRANSCRIBE_HIP=ON so the build goes through the upstream wrapper: GGML_HIP is set correctly and the HIP PIC codegen fix applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR handy-computer#121 (223c9b0) introduced a
TRANSCRIBE_HIPoption that wrapsGGML_HIPviaFORCE, plus a PIC codegen fix for the hipcc/ROCm static-archive link problem that is guarded byTRANSCRIBE_HIP.Our ROCm CI jobs were still passing
-DGGML_HIP=ONdirectly. That left the new PIC fix disabled — the jobs only kept working becauseBUILD_SHARED_LIBS=ONhappened to turn PIC on via ggml. Switch both the Linux and Windows ROCm-CPU configure steps to-DTRANSCRIBE_HIP=ONso the build goes through the upstream wrapper:GGML_HIPis set correctly and the HIP PIC codegen fix applies.Verification
Workflow run #30743739902 — all 9 steps passed, including Linux ROCm-CPU (reliable signal) and Windows ROCm-CPU (best-effort).
Inspected the built
transcribe.dll(commit7c598f1):transcribe-link.jsonreports"backends": ["rocm", "cpu"]transcribe_*).hipFatB(4KB) +.hip_fat(~394MB) confirm the HIP fat binary is embeddedgfx1100/1101/1102/1150/1151/1200/1201amdhip64_7.dll,hipMalloc,hipMemcpy2DAsync, …) and HIP kernels (snake_kernel,tri_kernel,quantize_q8_1) are in the fat binaryChanges