Conversation
Fixes govulncheck failures from GO-2026-4971 (net NUL byte panic) and GO-2026-4918 (HTTP/2 SETTINGS_MAX_FRAME_SIZE infinite loop).
Circuit.Extend (EXTENDED2) and Circuit.ReceiveRelaySetup (RENDEZVOUS_ESTABLISHED, INTRODUCE_ACK, RENDEZVOUS2) read from the link's per-circuit channel without a deadline. A silent or unresponsive relay/service therefore hangs setup indefinitely; in CI this consumed the full 10-minute test budget on TestE2ECircuitRetry before the first attempt's middle hop ever timed out. receiveCreated2 already imposes 30s; the multiplexing rewrite that moved cell reads onto channels (commit 30e9ad1) added that timeout but missed the matching ones for EXTEND and onion setup. Add a deadline-aware receiveRelayBefore helper, give Extend 30s, and plumb a timeout through ReceiveRelaySetup (30s for RENDEZVOUS_ESTABLISHED/INTRODUCE_ACK, 60s for RENDEZVOUS2 since the service must build a circuit back). Add unit tests covering both the timeout firing and the receiver-Done path.
Go 1.26.3 ships crypto/sha3 in the standard library, and govet's new inline analyzer flags golang.org/x/crypto/sha3.New256 (now a thin wrapper) for inlining. Switch all onion/*.go uses to stdlib, rename NewShake256 -> NewSHAKE256, and discard hash Write return values explicitly (errcheck no longer recognises the receiver as a hash.Hash-equivalent default-excluded type). x/crypto remains required for curve25519.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.