Fixing getEpisodeTVDB#59
Open
maximebeckman wants to merge 4 commits into
Open
Conversation
VideoLibrary.GetEpisodeDetails return throw exception sometimes. Unique_id don't always have the property "unknown" set. So use "tvdb" instead
|
766f-15ed |
mjglpn
approved these changes
Jan 30, 2018
TheOzzyman
approved these changes
Feb 19, 2018
TheOzzyman
left a comment
TheOzzyman
left a comment
There was a problem hiding this comment.
I've tried here the change and it's worked perfectly !
|
I've also tried the fix suggested in this commit and it's working! Thanks to @Silentbob1402, hopefully it will get merge soon for others to use. |
|
Is this getting merged? |
the-lazy-fox
suggested changes
Apr 25, 2018
| episode_id = result['result']['episodedetails']['uniqueid']['unknown'] | ||
| if 'tvdb' in result['result']['episodedetails']['uniqueid']: | ||
| episode_id = result['result']['episodedetails']['uniqueid']['tvdb'] | ||
| else: |
There was a problem hiding this comment.
episode_id = result['result']['episodedetails']['uniqueid']['imdb'] may also exist. You should add an extra if for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VideoLibrary.GetEpisodeDetails return throw exception sometimes.
Unique_id don't always have the property "unknown" set.
So use "tvdb" instead