[codex] Fix false positives for JsonRpcErrorCode comparisons#192
Closed
ded-furby wants to merge 1 commit into
Closed
[codex] Fix false positives for JsonRpcErrorCode comparisons#192ded-furby wants to merge 1 commit into
ded-furby wants to merge 1 commit into
Conversation
Owner
|
Thanks for the PR! We landed the same fix in v0.9.20 (#191) — scoped the scan to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonRpcErrorCode.Xdetection inlintErrorContractConformancetothrow new McpError(...)sites instead of any enum reference in the handler sourceerr.code === JsonRpcErrorCode.NotFoundfollowed byctx.fail(...)Root cause
The conformance heuristic treated every
JsonRpcErrorCode.Xtoken as a direct throw, so comparison logic inside catch/switch flows triggerederror-contract-prefer-faileven when the handler routed correctly throughctx.fail(...).Validation
bunx vitest run --project unit tests/unit/linter/error-contract-rules.test.tsbunx vitest run --project unit tests/unit/linter/*.test.tsCloses #191.