Fix for kubernetes client renaming V1Subject to RbacV1Subject#84
Open
stefan2200 wants to merge 1 commit intocyberark:masterfrom
Open
Fix for kubernetes client renaming V1Subject to RbacV1Subject#84stefan2200 wants to merge 1 commit intocyberark:masterfrom
stefan2200 wants to merge 1 commit intocyberark:masterfrom
Conversation
…till supporting the old kubernetes client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desired Outcome
V1Subject is only available as RbacV1Subject since library version 29
Implemented Changes
Try importing V1Subject if it fails import RbacV1Subject as V1Subject
Connected Issue/Story
None that I'm currently aware of. Just did a clean git pull and encountered this issue with the latest Python version and the most recently installed
kubernetespackage.Definition of Done
pip3 install --upgrade kubernetesand observe that it fails to import V1Subject from the kubernetes.client library. Fixing the import solves the issue and KubiScan works fine again.