Conversation
UI and downloading needs reworking, but hurrah so far.
| package net.cyclestreets.api | ||
|
|
||
| data class Map( | ||
| val id: String, |
There was a problem hiding this comment.
picky, but 8 characters indentation seems excessive.
Also I wonder if we would be better off naming this class differently - e.g. MapPack - so we don't confuse it with the native Map class in Kotlin and/or Java.
If you agree with this we could probably update the naming of the Maps class, and possible the getMaps method also.
There was a problem hiding this comment.
I now see it can't be MapPack as that would conflict.
What about MapReference or something similar; as effectively it acts as a reference to a downloadable map pack?
There was a problem hiding this comment.
I started with MapPack, realised, changed to Map as a holding name, now considering DownloadableMap
| return Maps( | ||
| featureCollection.features | ||
| .map { f -> toMap(f) } | ||
| .filter { m -> isBritainOrIreland(m) } |
There was a problem hiding this comment.
I agree with this restriction as a starting point. We can consider adding others subsequently as part of #46.
|
|
||
| class MapPack private constructor( | ||
| private val map: Map | ||
| ) { |
There was a problem hiding this comment.
I think this would read easier as a one-liner rather than these 3 lines, but maybe that's just me.
|
|
||
| class Maps( | ||
| private val packs: Collection<Map> | ||
| ): Iterable<Map> { |
There was a problem hiding this comment.
I think this would read easier as a one-liner rather than these 3 lines, but maybe that's just me.
|
I see this is still in partial state at present (clearly some more work to be done in terms of actually getting hold of the map pack, etc!) but hopefully my comments may still have some value. |
Map was a foolish name in the first place :)
We'll be retiring the external map packs so we won't need to support changing the map through the launch intent.
Needs some more attention, particularly around okaying with the user, and once the download has finished, but it's a step along the road.
|
It doesn't look like much, but this a rendering a vector map that the app has downloaded from the CycleStreets server, using the Android DownloadManager. There's still some more work to do on the UI elements - should probably ask if it's ok to download when not on Wifi, a way to uninstall them, etc, and on background updating - but moving in the right direction. |
|
Good work @jezhiggins! 🙌 |
It's causing crashes on some phones, and will be replaced with a new mechanism soon, see PR #417.
It's causing crashes on some phones, and will be replaced with a new mechanism soon, see PR #417.
2 participants
Downloading and managing map packs within the main app.