Reimplement backup files on Dart part#309
Draft
Sosthene00 wants to merge 7 commits intowallet_sqlitefrom
Draft
Conversation
Sosthene00
force-pushed
the
wallet_sqlite
branch
from
6ec73ef to
17f6fce
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
5d16b55 to
15b79a9
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
from
17f6fce to
766b6b5
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
15b79a9 to
1c0f58b
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
from
766b6b5 to
db326e1
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
1c0f58b to
709ae7f
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
from
db326e1 to
acb7eb8
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
709ae7f to
1b00134
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
from
acb7eb8 to
3302bbc
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
1b00134 to
280c2a9
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
from
3302bbc to
ee6c7b3
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
280c2a9 to
d9b19b4
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
from
ee6c7b3 to
9f1c951
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
d9b19b4 to
46b4667
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
3 times, most recently
from
d147463 to
a87a3f8
Compare
cygnet3
force-pushed
the
wallet_sqlite
branch
2 times, most recently
from
64a0ab1 to
6a769d5
Compare
Sosthene00
force-pushed
the
update_backup
branch
from
46b4667 to
668e49a
Compare
Sosthene00
force-pushed
the
wallet_sqlite
branch
2 times, most recently
from
8c1476b to
fd1bfa3
Compare
Collaborator
Author
|
Just to keep that in mind, this PR may be the opportunity to adhere to some standard, as proposed by the Liana team: https://github.com/pythcoiner/bips/blob/bip_wallet_backup/bip-wallet-backup.md |
Sosthene00
force-pushed
the
wallet_sqlite
branch
4 times, most recently
from
a1bf52d to
ed4f586
Compare
`Walletbackup`, `TransactionDataBackup`, `OwnedOutputBackup`, `IncomingTxBackup`, `OutgoingTxBackup`, `RecipientBackup`, `SettingsBackupData`
Sosthene00
force-pushed
the
update_backup
branch
from
668e49a to
65a640b
Compare
cygnet3
force-pushed
the
wallet_sqlite
branch
2 times, most recently
from
669c815 to
4e9f112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File backup is broken by #272, and after careful thinking I think it makes more sense to have it on the dart side of the code instead of rust.
This PR proposes a reimplementation of the existing backup system modified to adhere to the new sqlite database. It also added a proper key derivation from user password with a salt and pbkdf2. Note there's still no check on the user input, the constraints we want to impose are left to be discussed on another PR.