fix: Login/Password of Node dialog can't be made empty after setting a value#1062
Merged
julian-CStack merged 3 commits intocypherstack:stagingfrom Jan 13, 2025
Merged
fix: Login/Password of Node dialog can't be made empty after setting a value#1062julian-CStack merged 3 commits intocypherstack:stagingfrom
julian-CStack merged 3 commits intocypherstack:stagingfrom
Conversation
sneurlax
previously approved these changes
Jan 2, 2025
Member
|
I overlooked that using an empty string has consequences because null is expected for certain cases |
julian-CStack
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1061
The provider value will not be updated if set to null. So in this PR it will be set to the empty String instead of null.