fix: use cargo publish output for idempotency instead of REST API#16
Merged
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crate_version_exists()used crates.io REST API to check if a version was already published, butcargo publishuses the local registry index. These two sources are not synchronized — the REST API can lag behind, causingcargo publishto fail witherror: crate ... already existseven though the REST API check passed.Fix
Replaced REST API pre-check +
wait_for_crateloop with a simpler approach:cargo publishis always attempted"already exists"in stderr → caught and skipped gracefullyChanges
crate_version_exists()andwait_for_crate()bash functionscurlandjqdependency from the publish steppublish_crate()now capturescargo publishstderr+stdout and inspects output