Conversation
The array goes into BSS and will be zeroed anyway.
No need to worry about updating DEVICE_TYPE_COUNT when adding new devices.
…omputing for MOVI instructions
…g, add checks for alignment and add basic accounting
This commit makes the INTC as its own independent device and also changes the SH-2E CPU step behaviour. Now the CPU step mimicks one step in the CPU state automaton instead of executing one instruction per step.
Added reference between SH-2E cpu and interrupt controller. Changed the resets behaviour to be similiar to interrupt sources. Also added some example configuration to the msim.conf file.
|
Hello, I would leave the technical review to @lbulej but I have two (formal) objections. There is no documentation update in Also, it would be really nice if the whole source code was formatted in the same style. I think that reformatting everything is an option too but I do not see any really strong reason for it at the moment. Apart from that, I really like the amount of tests that you have added. That is really nice. Thank you. |
|
Hello, I added documentation for the CPU and INTC, and updated the documentation for the printer device. I also introduced additional debugging features for both the CPU and INTC. Lastly, I removed the separate formatting for the SuperH files and I would leave the updated formatting for another discussion. |
3 participants
This pull request adds support for the SH-2E CPU to MSIM.
Main changes include:
Clang format changes