deploy: keep Monaco WASM raw - #106
Merged
Merged
Conversation
alixander
marked this pull request as ready for review
August 6, 2026 05:11
alixander
enabled auto-merge
August 6, 2026 05:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dist/js/vendor/onig.wasmWhy
The deploy script synced
distfirst and then replaceddist/js/vendor/onig.wasmwith Brotli bytes without uploading it or attachingContent-Encodingmetadata. Reusing that mutated directory for the source-account mirror stored compressed bytes as an ordinary WASM object. The live CloudFront distribution compressed it again, and browsers received Brotli bytes instead of the WebAssembly magic header, preventing Monaco from initializing.Keeping WASM raw makes the build directory safe to re-sync and mirror. Any future precompression must use matching object metadata.
Impact
Future playground deploys and mirrors will publish a directly usable
onig.wasminstead of leaving a hazardous post-deploy artifact. This does not change the explicit Brotli handling for the large JavaScript and CSS bundles.Validation
bash -n ci/deploy.shgit diff --checkNo new test was added.