d2latex: replace MathJax JavaScript with mathjax-go - #2824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
The native port targets the exact custom MathJax 3.2.2 component previously embedded by D2. The unchanged D2 E2E golden suite passes byte-for-byte; no golden was refreshed. This includes AMS, Mathtools, AMS-CD, braket, chemistry, physics, colors, errors, scripts, tables, and the historical backslash boundary.
The dependency is pinned to the signed mathjax-go v0.1.0 tag, with no local replace or pseudo-version.
Validation
The two GIF cases in e2etests-cli cannot produce browser frames in this local environment and fail identically on untouched D2; all non-browser packages pass.
Size impact
Measured against the parent D2 revision with identical build flags:
Standalone port
Merged: d2lang/mathjax-go#1