d2sketch: upgrade to Rough.js 4.6.6 - #2845
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: d2lang/rough-go#2
Summary
Compatibility
This changes seeded sketch SVG path data. It does not change diagram layout, board JSON, IDs, text, style semantics, or the non-sketch renderer.
The accepted update contains 40 SVGs: 33 focused d2sketch fixtures, 6 E2E fixtures, and 1 CLI fixture. Thirty-six keep identical SVG structure and path counts while updating only path data. The other four are the light/dark arrowhead and crow's-foot matrices, where current Rough.js emits fewer internal paths for filled markers; visual review confirms the rendered markers remain intact.
The dependency is the signed rough-go
v0.2.0release, which targets the merged native-port PR exactly.Validation
CI=1 go test -mod=readonly --timeout=30m -count=1 ./...go test -race, fullgo vet, native build, and Go WASM build