⚡ Bolt: Optimize BDS inference by removing string allocations#114
⚡ Bolt: Optimize BDS inference by removing string allocations#114d3mocide wants to merge 1 commit into
Conversation
Replaced bitwise operations, string formatting, and set lookups with direct byte comparison in `infer_bds`. This executes ~3.7x faster and avoids string allocations in a hot path. Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
Replaced bitwise shifting/masking, f-string formatting, and set lookup with a direct byte equality comparison in
infer_bds(poller/normalizers/bds_decoders.py).🎯 Why:
infer_bdsis called for every 14-byte Comm-B reply. The original implementation created temporary strings (e.g."4,0") and performed a set lookup. By checking the raw byte integer directly (e.g.,0x40), we avoid heap allocations entirely and bypass Python's hashing logic.📊 Impact:
Executes ~3.7x faster.
🔬 Measurement:
A quick benchmark of 1,000,000 runs parsing all 4 valid BDS codes plus one invalid code:
PR created automatically by Jules for task 2094442677375073617 started by @d3mocide