Skip to content

fix: migrate module paths to dappco.re#3

Merged
Snider merged 17 commits intomainfrom
dev
Apr 4, 2026
Merged

fix: migrate module paths to dappco.re#3
Snider merged 17 commits intomainfrom
dev

Conversation

@Snider
Copy link
Copy Markdown
Contributor

@Snider Snider commented Apr 4, 2026

Module path migration from forge.lthn.ai to dappco.re

Summary by CodeRabbit

  • New Features

    • Added DeleteMany() method to remove multiple cache entries in a single operation.
  • Bug Fixes

    • Improved safety with validation for invalid cache states.
    • Enhanced time-to-live (TTL) validation to reject invalid durations.
  • Documentation

    • Published API contract reference table for all exported methods.
    • Added architecture and security analysis documentation.

Virgil and others added 17 commits March 22, 2026 17:20
… $(go version) — $(un...' (#6) from agent/run--echo--hello-from---hostname------go into dev
Co-Authored-By: Virgil <virgil@lethean.io>
… $(go version) — $(un...' (#7) from agent/run--echo--hello-from---hostname------go into dev
…d CLAUDE.md first. AX: fi...' (#9) from agent/fix-all-findings-from-issue--4--read-cla into dev
Co-Authored-By: Virgil <virgil@lethean.io>
…d CLAUDE.md. Map every ex...' (#12) from agent/security-attack-vector-mapping--read-cla into dev
Co-Authored-By: Virgil <virgil@lethean.io>
…E.md. For every exported ...' (#15) from agent/api-contract-extraction--read-claude-md into dev
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 4, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The cache implementation has been refactored to replace filesystem-specific path handling with medium-agnostic helpers whilst adding configuration/readiness guards. Error handling and serialization now leverage core utilities. TTL validation was introduced, and a bulk deletion API (DeleteMany) was added. Tests were comprehensively expanded, and documentation covering API contracts, architecture, and security analysis was added. Module dependencies were updated to target a newer core version.

Changes

Cohort / File(s) Summary
Core Implementation Refactoring
cache.go
Replaced filepath and os operations with core.JoinPath, core.CleanPath, and core.Concat for path handling. Introduced ensureConfigured and ensureReady guards to fail early when cache is misconfigured. Updated serialization to use core.JSONMarshal and core.JSONUnmarshal, with TTL validation rejecting negative values. Changed error checking from os.ErrNotExist to fs.ErrNotExist. Added DeleteMany(keys...) API for bulk deletion. Updated key helper functions to use medium-agnostic path construction.
Test Suite Expansion
cache_test.go
Replaced single monolithic test with focused test suite covering constructor TTL validation, path handling with traversal rejection, get/set/expiry behaviour, receiver safety for nil and zero-value caches, bulk deletion semantics, and key helper validation. Introduced newTestCache and readEntry helpers for test infrastructure.
Documentation
docs/api-contract.md, docs/architecture.md, docs/security-attack-vector-mapping.md
Added new API contract reference documenting all exported symbols and test coverage. Updated architecture documentation for DeleteMany behaviour, path-traversal validation logic, and GitHub key helper implementations. Added comprehensive security attack vector mapping analysing input sources, validation present, and residual risks across the public API.
Dependency Management
go.mod
Updated to directly require dappco.re/go/core v0.8.0-alpha.1 and removed direct requirement for dappco.re/go/core/log v0.1.0, retargeting the indirect go-log dependency accordingly.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 13.04% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: migrate module paths to dappco.re' accurately describes the main change in the changeset—updating module paths and dependencies from forge.lthn.ai to dappco.re. However, the changeset encompasses significantly more substantial work, including core cache functionality improvements, new test coverage, security documentation, and API contract documentation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Snider Snider merged commit 2ad3b05 into main Apr 4, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant