Skip to content

Fix norm estimation to not retunr nan for cases of 0 or 1 monomials #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abgandar merged 2 commits into from
Mar 21, 2025
Merged

Fix norm estimation to not retunr nan for cases of 0 or 1 monomials #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2179e6
Fix norm estimation for cases of 0 or 1 monomials
abgandar Mar 21, 2025
fbbb429
fix memory leak in previous commit
abgandar Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/dacenorm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ void daceOrderedNorm(const DACEDA *ina, const unsigned int ivar, const unsigned
of the exponential fit at each order. If NULL is passed in, no residuals
are computed and returned.
\note If estimation is not possible, zero is returned for all
requested orders. in most cases this is actually not too far off.
requested orders. In most cases this is actually not too far off.
*/
void daceEstimate(const DACEDA *ina, const unsigned int ivar, const unsigned int ityp, double c[], double err[], const unsigned int nc)
{
Expand Down Expand Up @@ -240,7 +240,13 @@ void daceEstimate(const DACEDA *ina, const unsigned int ivar, const unsigned int
}

if(xtx[1][1] < 2)
{
daceSetError(__func__, DACE_INFO, 63);
#if DACE_MEMORY_MODEL != DACE_MEMORY_STATIC
dacefree(onorm);
#endif
return;
}

xtx[1][0] = xtx[0][1];
const double det = xtx[0][0]*xtx[1][1]-xtx[0][1]*xtx[1][0];
Expand Down