merge in the new redperms#22
Merged
nikomatsakis merged 18 commits intodada-lang:mainfrom Apr 27, 2025
Merged
Conversation
Really we ought to test that that the two are equivalent.
This has been helpful but I think this way of looking at reduction is not the right one.
I don't think they are needed; expansion will mean that we are applying to shared, and we have a separate rule for that
The old code was not correct as it didn't account for the liveness of temporaries. This matters more as we experiment with alternate formulations.
and skip the one test that fails as a result
Begin with `share` and `our`. We will be adding `guard` next.
This allows us to align the behavior around guards between the redperms and the subperms. It also means we remove some of the sketchy upcasting around dead places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redperm model is an alternate take on our subpermission rules that is meant to interact better with inference. We keep them both and check for consistency between them.