Add multiline description support, more helpful error messages#121
Open
felixvd wants to merge 2 commits intodadadel:masterfrom
Open
Add multiline description support, more helpful error messages#121felixvd wants to merge 2 commits intodadadel:masterfrom
felixvd wants to merge 2 commits intodadadel:masterfrom
Conversation
a-t-0
suggested changes
May 14, 2022
There was a problem hiding this comment.
Dear Felix, thank you for your work. I was trying to review your code and thought it would be easier to understand if you could include a test case that demonstrates how your adaptations change the behaviour of pyment. (I noted your example on the support for multiline in the comment with the pull request). Would you perhaps be willing and able to write two of such tests?
- Possibly one to demonstrate how your adaptation yields more helpful error messages.
- And perhaps one that demonstrates the support for multiline descriptions?
Note, I have no affiliations with pyment, however I noticed it has not been updated in almost 1.2 years, so I thought it would be nice to show some interaction to perhaps get the ball rolling (again).
Contributor
|
Hi, what's the status on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered some cases that don't tell the user what to fix. This catches the exception and localizes the error.
It also supports multi-line comments.
Example: