Skip to content

fix(control): use DNS handoff when choosing dial target - #1081

Open
Zhanfg wants to merge 1 commit into
daeuniverse:mainfrom
Zhanfg:fix/dns-handoff-choose-dial-target-1054
Open

fix(control): use DNS handoff when choosing dial target#1081
Zhanfg wants to merge 1 commit into
daeuniverse:mainfrom
Zhanfg:fix/dns-handoff-choose-dial-target-1054

Conversation

@Zhanfg

@Zhanfg Zhanfg commented Aug 16, 2026

Copy link
Copy Markdown

Background

During DNS controller handoff, ChooseDialTarget() could still consult the old c.dnsController directly instead of the controller currently active through the handoff mechanism.

If DNS knowledge exists only in the handoff controller, the old lookup misses it and the dial target can incorrectly remain an IP address instead of switching back to the original domain.

This change uses ActiveDnsController() and handles the nil case before consulting DNS knowledge.

A regression test reproduces the handoff state and verifies that the domain is selected and rerouting is requested.

Checklist

Full Changelogs

  • Use the active DNS handoff controller when deciding whether a dial target should use its original domain.
  • Add a regression test covering DNS knowledge stored in the handoff controller.

Issue Reference

Closes #1054.

Test Result

  • Added TestChooseDialTargetUsesDNSHandoff.
  • Fork CI for the corrected regression fixture passed.
  • Upstream CI is awaiting maintainer approval for fork-originated workflows.

@Zhanfg
Zhanfg requested a review from a team as a code owner August 16, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] Panic in ChooseDialTarget during staged DNS controller handoff

1 participant