build is using json-glib-1.0 but configure isnt checking for it

[darix]

just later on during the build it tries to somehow access it.

[dagargo]

Fixed in 8ef69f6.

Let me know if this actually fixes the issue for you.

Thanks for reporting this, @darix!

[darix]

looks fine to me. will report back after the next release if it is still an issue.

my opensuse package is at https://build.opensuse.org/package/show/home:darix:playground/elektroid for now. might find a more prominent place for it later.

I was curious. what was the reason of splitting out the cli in your own spec.

also if you look at my spec ... if you can convert your BuildRequires to the pkgconfig() format ... it should become a bit more distribution independent

[dagargo]

I was curious. what was the reason of splitting out the cli in your own spec.

It traces back to the first versions. The idea was to build it on much lower requirements systems or even in systems without a GUI. In fact, the configure option was called CLI_ONLY. It only changed to BUILD_CLI and BUILD_GUI last June. Perhaps I should remove this entirely. I'll think about it.

also if you look at my spec ... if you can convert your BuildRequires to the pkgconfig() format ... it should become a bit more distribution independent

You mean converting specs like BuildRequires: pkgconfig(alsa) >= 1.1.3 into PKG_CHECK_MODULES?

BTW, I've just lowered the required version from 1.10 to 1.8 to make it buildable over Ubuntu 24.04.

[darix]

naw. you have some conditionals for use libpulse-devel for suse but another name for other distros.
all those devel packages on modern rpm based distributions would provide pkgconfig(pulse...) so if you switch your package name buildrequires over. you can remove all the %if. it also makes converting from PKG_CHECK_MODULE to the rpm format a lot easier. This is what I did last night. I just copy pasted the PKG_CHECK_MODULE from the configure.ac to the spec file and then s/// :D

BuildRequires:  pkgconfig(alsa) >= 1.1.3
BuildRequires:  pkgconfig(gtk+-3.0)
BuildRequires:  pkgconfig(json-glib-1.0)
BuildRequires:  pkgconfig(libzip) >= 1.1.2
BuildRequires:  pkgconfig(rtaudio)
BuildRequires:  pkgconfig(rtmidi)
BuildRequires:  pkgconfig(rubberband) >= 3.3
BuildRequires:  pkgconfig(samplerate) >= 0.1.8
BuildRequires:  pkgconfig(sndfile) >= 1.0.2
BuildRequires:  pkgconfig(zlib) >= 1.1.8
BuildRequires:  pkgconfig(libpulse-mainloop-glib)

hth

for the package split. ok then i will leave them in one package for opensuse now.

p.s.: in case you wonder how I found you ... I am running the server that hosts librearts.org and prokoudine reported about the release and i just started looking into elektron boxes myself. so now was the time to fix the missing package.

[dagargo]

Of course! I didn't understand because I was looking at configure.ac instead of the spec file included in the project. 🤦‍♀️
On top of that, I didn't know SUSE uses the spec files as well.

Anyway, I included this file because @jwakely asked me. Or so I remember.
What it happens is that the file is quite dated and would need some changes.

I think we should keep it to date and make it usable by anyone needing a spec file.
@jwakely, is this OK from the Fedora/RedHat POV? @darix, can I merge your file into Elektroid? Does anybody want to create a PR?

[darix]

if you want the pkgconfig() BuildRequires i can do a PR.

(JFYI: obs can build for multiple distros if you want upstream packages for elektroid)

edit: I could of course just use OBS to test the fedora build:

https://build.opensuse.org/project/monitor/home:darix:elektroid

openSUSE Leap 16.0 does not build because of an too old rubberband library.