Draft: prototype global Berkovich-space core - #34
Draft
dagurtomas wants to merge 1 commit into
Draft
Conversation
Preserve the agent's locally ringed topological-space, analytic-morphism, and affinoid-chart prototype for review. This remains an incomplete draft and does not currently elaborate past the affinoid-core construction.
This was referenced Jul 23, 2026
Owner
Author
|
Review confirms that this prototype is too broad for one implementation track. It also has two architectural problems: The work is now split into:
Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Early draft — currently does not compile and must not be merged. Tracks #21.
This preserves the Berkovich-space agent's partial implementation for review. It does not replace any comparator
sorry.Implemented prototype
PreBerkovichSpace, a locally ringed topological-space interface;BerkovichSpacebundle and morphism/category API.Current build blocker
lake build -q Rigid.Berkovich.Spacefirst fails while constructingAffinoidBerkovichCore:AffinoidAlgebraModelsupplies onlyCommRingandAlgebra, whileBerkovichSpectrumOverneeds the normed/complete structures associated to an affinoid presentation. Errors after that point are cascading unknown-declaration failures.Required redesign before merge
Checks
Passed:
./scripts/check_root_imports.sh./scripts/check_challenge_development.shgit diff --checksorryinRigid/Berkovich/Space.leanFailing as described above:
lake build -q Rigid.Berkovich.Spacelake build -q Rigid