Skip to content

Expand HVAC capability inference from known unit types#114

Merged
dahlb merged 3 commits into
dahlb:mainfrom
Snuffy2:Enhance-logic-for-hot/cool/fan
Jul 6, 2026
Merged

Expand HVAC capability inference from known unit types#114
dahlb merged 3 commits into
dahlb:mainfrom
Snuffy2:Enhance-logic-for-hot/cool/fan

Conversation

@Snuffy2

@Snuffy2 Snuffy2 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Expand HVAC capability inference to supplement Carrier energy flags with known indoor and outdoor unit-type hints, while keeping the public API unchanged.

What Changed

  • Added internal normalization for raw profile unit-type comparisons.
  • Added outdoor-unit fallbacks for:
    • multistghp -> heat and cool
    • multistgac -> cool
    • varcaphp -> heat and cool
    • varcapac -> cool
    • ac2stg -> cool
    • ac1stg -> cool
  • Added indoor-unit fallbacks for:
    • furnace -> heat
    • fancoil -> fan
  • Extended regression coverage for canonical, mixed-case, and whitespace-variant unit-type strings.

Why

Some Carrier installations do not report a capability through energyConfig even when the equipment is known to support it. These unit-type hints provide a conservative supplemental signal without changing the public API surface.

Validation

  • ./.venv/bin/pytest
  • ./.venv/bin/prek run --all-files

Fixes dahlb/ha_carrier#400

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/carrier_api
  system.py 188
Project Total  

This report was generated by python-coverage-comment-action

@Snuffy2 Snuffy2 force-pushed the Enhance-logic-for-hot/cool/fan branch from 4a2dc5c to d27fea5 Compare July 6, 2026 12:41
@dahlb dahlb merged commit 6b1071a into dahlb:main Jul 6, 2026
3 checks passed
@Snuffy2 Snuffy2 deleted the Enhance-logic-for-hot/cool/fan branch July 6, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can’t Select Cool in Home Assistant

2 participants