Route SQL through V2 ANTLR parser in unified query path#20
Draft
dai-chen wants to merge 1 commit into
Draft
Conversation
Add SqlV2QueryParser that wraps SQLSyntaxParser and AstBuilder to produce UnresolvedPlan, enabling MySQL-compatible syntax (backtick identifiers, MATCH, SHOW TABLES LIKE, ODBC escapes) in the unified query pipeline. Switch UnifiedQueryContext and UnifiedQueryPlanner to use SqlV2QueryParser + CustomVisitorStrategy exclusively for SQL, replacing the Calcite native parser path. Existing SQL tests written for the Calcite native parser are @ignored with migration message. New UnifiedQueryPlannerSqlV2Test covers the V2 parser path end-to-end. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/sql-v2-antlr-unified-query-path
branch
from
b52ac6d to
1bb0747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SqlV2QueryParser that wraps SQLSyntaxParser and AstBuilder to produce UnresolvedPlan, enabling MySQL-compatible syntax (backtick identifiers, MATCH, SHOW TABLES LIKE, ODBC escapes) in the unified query pipeline.
The V2 parser is opt-in via UnifiedQueryContext.builder().ansiSql(false). ANSI mode (Calcite native parser) remains the default, preserving all existing behavior. UnifiedQueryPlanner selects CalciteNativeStrategy or CustomVisitorStrategy based on the parser type.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.