fix(ci): stabilize npm release and catalog e2e workflows - #550
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates catalog E2E dependency and execution settings. It also changes the agentsync TypeScript configuration to use Node16 modules and module resolution. ChangesCatalog E2E workflow
TypeScript module configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|



Description
Stabilizes the npm release workflow and the catalog E2E workflow.
Two CI failures addressed:
npm/agentsyncwrapper usedmoduleResolution: "node", which maps to the removednode10resolution in TS 7 and fails withTS5108: Option 'moduleResolution=node10' has been removedin thePublish NPM Base Packagejob.offlinejob rancargo test --offlinewithout guaranteeing dependencies were fetched on the runner, failing witherror: no matching package named 'anyhow' foundduring resolution.Changes
npm/agentsync/tsconfig.json: migratemoduleandmoduleResolutiontoNode16(replaces
commonjs/node). Validated against TS 7.0.2:Node16,NodeNext, andpreserve+bundlerall pass;commonjs+nodenextfailsTS5110;classicis removed..github/workflows/catalog-e2e.yml:Fetch locked dependencies before offline teststep (cargo fetch --locked).cargo test --test test_catalog_integration --locked --offline -- --nocapture.RUN_E2E: 1explicitly and uses--locked.Type of change
How Has This Been Tested?
pnpm --filter agentsync run typecheck— pass (TS 7.0.2, Node 24)pnpm --filter agentsync run build— passactionlint .github/workflows/catalog-e2e.yml— cleancargo test --test test_catalog_integration --locked --offline -- --nocapture— 1 passed, 0 failed, 1 ignoredgit diff --check— cleancargo fmt --all -- --check,cargo clippy --all-targets --all-features -- -D warnings) — cleanTest Configuration:
Checklist: