Skip to content

fix(a11y): associate waitlist email label and fallback channel avatar alt text - #1054

Merged
yacosta738 merged 1 commit into
mainfrom
fix/a11y-avatar-alt-waitlist-label
Sep 15, 2026
Merged

yacosta738 merged 1 commit into
mainfrom
fix/a11y-avatar-alt-waitlist-label

Conversation

@yacosta738

Copy link
Copy Markdown
Contributor

Rescues the two deterministic accessibility fixes from #970 into a minimal reviewable change.

Changes:

  • apps/web/marketing/src/components/WaitlistForm.astro: visible email text uses label[for=waitlist-email] instead of a span
  • apps/web/marketing/src/components/WaitlistForm.test.ts: regression coverage for the label association
  • apps/web/app/src/modules/publishing/presentation/components/ComposerChannelSelector.vue: generic Channel avatar alt text when the channel name is missing
  • apps/web/app/src/modules/publishing/presentation/components/ComposerChannelSelector.test.ts: regression coverage for both alt variants

Verification:

  • New tests watched failing first, then green after the fix (TDD)
  • Marketing suite: 15 files / 139 tests pass
  • App publishing module: 32 files / 817 tests pass
  • Pre-push hooks green: backend-detekt, backend-spotless, backend-test, shared-detekt, gitleaks

Related #970 (superset PR to be closed once this is green).

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a71c49ab-2070-4aa7-8611-9f45b25033ae

📥 Commits

Reviewing files that changed from the base of the PR and between 5aef681 and 5ce8781.

📒 Files selected for processing (4)
  • apps/web/app/src/modules/publishing/presentation/components/ComposerChannelSelector.test.ts
  • apps/web/app/src/modules/publishing/presentation/components/ComposerChannelSelector.vue
  • apps/web/marketing/src/components/WaitlistForm.astro
  • apps/web/marketing/src/components/WaitlistForm.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area:frontend Changes in frontend marketing site (apps/web/marketing/**) type:test Test files or test infrastructure changes labels Sep 15, 2026
@github-actions

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying profiletailors with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ce8781
Status: ✅  Deploy successful!
Preview URL: https://ae9d8621.profiletailors-com.pages.dev
Branch Preview URL: https://fix-a11y-avatar-alt-waitlist.profiletailors-com.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying app-profile-tailors with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ce8781
Status: ✅  Deploy successful!
Preview URL: https://0a08ba5b.app-profile-tailors.pages.dev
Branch Preview URL: https://fix-a11y-avatar-alt-waitlist.app-profile-tailors.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying profiletailors-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ce8781
Status: ✅  Deploy successful!
Preview URL: https://809ca829.profiletailors-com-bx5.pages.dev
Branch Preview URL: https://fix-a11y-avatar-alt-waitlist.profiletailors-com-bx5.pages.dev

View logs

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yacosta738
yacosta738 merged commit da92132 into main Sep 15, 2026
53 of 55 checks passed
@yacosta738
yacosta738 deleted the fix/a11y-avatar-alt-waitlist-label branch September 15, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Changes in frontend marketing site (apps/web/marketing/**) type:test Test files or test infrastructure changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant