Add asynchronous Stream serializer APIs - #201
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 53 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (62.90%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 95.19% 94.05% -1.14%
==========================================
Files 125 127 +2
Lines 3394 3518 +124
Branches 464 488 +24
==========================================
+ Hits 3231 3309 +78
- Misses 90 128 +38
- Partials 73 81 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Some Stream implementations permit only asynchronous reads and writes. These APIs make them usable without changing LightProto's synchronous
ReaderContextandWriterContextcodec contracts.Validation
dotnet build src\\LightProto\\LightProto.csproj -c Release --no-restoredotnet test tests\\LightProto.Tests\\LightProto.Tests.csproj -c Debug --no-restore --timeout 60s --minimum-expected-tests 1git diff --checkThe test suite includes an async-only Stream regression test and passed 13,543 tests.