Add custom repeated parser support - #205
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 24 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dameng324
force-pushed
the
feature/custom-repeated-parsers
branch
from
August 2, 2026 09:29
34c52d9 to
13c9113
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 95.52% 95.55% +0.02%
==========================================
Files 127 127
Lines 3665 3665
Branches 518 518
==========================================
+ Hits 3501 3502 +1
Misses 90 90
+ Partials 74 73 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProtoRepeatedParserTypeandProtoRepeatedParserTypeMapfor customIEnumerable<T>repeated-field adapters.Why
Custom collection types previously fell through to the built-in collection parser selection and could not provide their own repeated reader/writer pair while preserving protobuf repeated wire semantics.
Validation
dotnet test LightProto.slnx --no-restore --configuration Release -p:PublishAot=false --coverage --coverage-output-format cobertura --coverage-output coverage.cobertura.xmldotnet tool run csharpier -- check .