feat: add support for lock and private on nix based systems - #95
Open
dignifiedquire wants to merge 1 commit into
Open
feat: add support for lock and private on nix based systems#95dignifiedquire wants to merge 1 commit into
dignifiedquire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have not used memmap on Windows, I am unclear if it is possible to support these options on Windows. But these are quite important to support when using memmap in a perf oriented manner, which is why I needed them.
I have tested it manually in my project, but the lock requires running with
sudousually, so I didn't add a test for now.