feat: remove broken assertions, add color test#30
feat: remove broken assertions, add color test#30m-clare wants to merge 2 commits intodancergraham:mainfrom
Conversation
m-clare
commented
Oct 27, 2024
- Added a test for checking a few point color values.
|
Thanks for this - On this one I wonder whether we should follow the same approach as the recent Intensity value fix, disabling color normalisation. When I export these color values into a text file (X, Y, Z, R, G, B, Intensity attached) using cloud compare I get Integer values. I think it makes sense for this library that the color values read back out should be as close as possible to the original written values or written using a common format and not normalised from 0 to 1 based on the range of values present in this pointcloud. |
|
I think simply calling |
|
This would again be a breaking change bu I think it's the right choice for this lib |
|
I think Actions should now run automatically on future PRs as you have already contributed ! |