Adapt LAD framework to dandi-cli project practices#1805
Conversation
- Remove numpy/pandas from dependency list (not used by this project)
- Remove leaked emuses/ references from another project across 7 files
- Replace FastAPI/Django/Flask examples with click CliRunner (CLI project)
- Replace hardcoded Python 3.11 with "see pyproject.toml"
- Replace raw pip install recommendations with tox/pre-commit references
- Replace generic config file creation with "verify existing configs"
- Update test commands to use tox -e py3 / python -m pytest dandi
- Replace project-specific test categories with generic {{category}} placeholders
- Update testing strategy to reflect CLI, API client, and file processing patterns
- Add @pytest.mark.ai_generated requirement to LAD CLAUDE.md
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
- Coverage 75.11% 75.10% -0.02%
==========================================
Files 84 84
Lines 11925 11925
==========================================
- Hits 8958 8956 -2
- Misses 2967 2969 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yarikoptic I don't quite understand, your PR description states things I would expect to see changed in source not just a bunch of AI prompts/skills |
|
I added opening to the description to point that it is just about |
|
It's just that when I read a PR description line of
I take that to mean that you modified the pyproject.toml But you are saying all you did was remove some text to the agents about restricting that? https://github.com/dandi/dandi-cli/pull/1805/changes#diff-f2f065b85fdc8fc2f7497ca92c577e258caf9bbed526dd15eee68f628d9cb0feL13 |
|
sorry -- I am not following. I just instructed clude to tune LAD framework to what we actually have in dandi-cli, hence it removed stuff which is not pertinent (e.g. stating pandas as dependency) and pointed to correct places (like |
|
Next time just set PR description to "Improvements to .lad framework" For each of the items above, I have or would expect to see a PR description given with that exact verbiage, but not affecting internal AI context and instead making the stated change to the actual source code itself. |
In
.lad/framework for AI agents this PR does:@pytest.mark.ai_generatedrequirement to LAD CLAUDE.mdThis should make it more up to the point of dandi-cli development!