Compute stats over all (not just nwb), and plot count and size as well in time #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
force-pushed
the
enh-stats2
branch
2 times, most recently
from
3f9d7ce to
9f1938c
Compare
Member
|
Why is the orange line on the second plot short? |
Member
Author
I think it is due to a bug :-( in dandi-archive: |
…l in time Temporal plot for size is suboptimally created since just orders by creation time, so later changes could potentially attributed to earlier time. But for the sake of visualization I think it is ok. Note: if re-doing for NWB only, ATM we have an issue that asset stats are not computed for embargoed, see discussion/pointers in #114 (comment)
Member
Author
|
I have pushed rewrite with up to date run. I would prefer to not wait for issues elsewhere to be resolved and just proceed with this as is for now . WDYT @bendichter ? |
Member
Author
|
Let's just go for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporal plot for size is suboptimally created since just orders by creation time, so later changes could potentially attributed to earlier time. But for the sake of visualization I think it is ok.
And if we revert back to plotting only NWB dandisets we would get
which is inline (ref @satra) with https://github.com/datalad/datasets.datalad.org-gitlog-stats/blob/master/plots/neurorepos-1.svg stating 335TB but includes only public dandisets and without zarrs, so here it would be dashed blue line and axis on the right.
TODOs
Notebook diff can be seen at https://app.reviewnb.com/dandi/example-notebooks/pull/114/