-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add XoAuth2 support #6388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hnolde
wants to merge
13
commits into
dani-garcia:main
Choose a base branch
from
hnolde:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add XoAuth2 support #6388
+405
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resh used by Google or Microsoft
BlackDex
requested changes
Oct 22, 2025
Collaborator
BlackDex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick glance on it and have some notes.
Need to look better at the code, but no time right now.
Collaborator
|
Sorry, didn't had much time to check and verify this PR yet in detail. I still have it on my list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive support for SMTP OAuth2 (XOAUTH2) authentication, enabling the system to send emails via providers that require OAuth2 (like Gmail). It introduces new configuration options, admin panel endpoints, and user interface controls for managing OAuth2 tokens and authorization flows. The implementation includes secure handling of OAuth2 state for CSRF protection, token caching, and robust validation of configuration parameters.
SMTP OAuth2 (XOAUTH2) Support
smtp_oauth2_client_id,smtp_oauth2_client_secret,smtp_oauth2_auth_url,smtp_oauth2_token_url,smtp_oauth2_refresh_token, andsmtp_oauth2_scopes. These allow the system to be configured for OAuth2-based SMTP authentication.Backend OAuth2 Flow and Token Management
/admin/oauth2/authorizeand/admin/oauth2/callback) and a token refresh endpoint (/admin/test/oauth2) in the admin API, including secure state storage for CSRF protection during the OAuth2 flow. [1] [2] [3] [4]SMTP Transport and Authentication Logic
Admin UI Enhancements
General Improvements
update_config_partialpublic to allow saving OAuth2 tokens from the OAuth2 callback handler.From<&str>implementation for theErrortype to simplify error handling.