Skip to content

VALUE-03A: consume declared generation domains - #149

Draft
daniele21 wants to merge 17 commits into
devfrom
feat/value-03a-declared-generation-domains
Draft

VALUE-03A: consume declared generation domains#149
daniele21 wants to merge 17 commits into
devfrom
feat/value-03a-declared-generation-domains

Conversation

@daniele21

Copy link
Copy Markdown
Owner

Parent: #144
Producer contract: daniele21/korgis#205

Outcome

Consume backend/model-owned request-generation parameter domains from Local LLM Server without inventing ranges or enabling configuration sweeps yet.

Boundary

  • /api/v1/models/registry enrichment remains first-party and best-effort.
  • GenerationParameterDomainReadModel validates the public producer shape and adds explicit scope=request_generation / source=local_llm_server while preserving provenance=registry_declared.
  • Domains stay model-scoped on DiscoveredModelReadModel and CandidateModelReadModel.
  • Runtime-load parameters remain separate and observational.
  • Malformed domain metadata is ignored with a warning; successful generic model discovery is preserved.

Deliberate VALUE-03A limit

This PR does not choose union/intersection semantics across models and does not expand a domain into configurations. bounded_generation_parameter_ranges remains empty and Quick/Standard/Thorough/Custom remain unavailable. Fixed remains the only executable strategy. Alias translation such as Korgis max_tokens -> Performance Lab max_output_tokens is deferred to VALUE-03B where it can be frozen into GenerationConfig, plan digest and Run fingerprints.

Tests

Focused contract tests cover:

  • valid Korgis numeric + boolean domains;
  • separation from runtime-load configuration;
  • malformed domain fail-closed behavior;
  • propagation into candidate planning while sweep strategies remain blocked.

Evidence boundary

Deterministic software semantics only. This makes no real-model/device/performance claim.

Integration gate

DO NOT MERGE while VALUE-02D #132 is not REAL_ENVIRONMENT PASS / VALUE-02 acceptance is not formally closed. Current dev already contains the VALUE-02 software integration, but #120 and #132 remain open; this PR does not reinterpret that as real acceptance.

Copy link
Copy Markdown
Owner Author

VALUE-03A software-ready — exact-head deterministic validation PASS

Exact branch head: caed430641d40228e9778155f5b8157daf5238a5
Base: dev@0b9c376f2dbcbb167f8df8488374c1b0c5d0ace2

Repository-owned evidence on this exact head:

  • Repository Health run 33766112408: PASS
  • Repository Validation run 33766112384: PASS
  • Python 3.12: PASS
  • Python 3.13: PASS
  • Frontend check/test/build: PASS
  • Browser/Product/Built Product: selector N/A / skipped for this isolated contract slice

Producer daniele21/local-llm-server#205 is now merged to Local LLM Server dev (e7e186c96b66f4ddb3a01e926b5a43b69aceeca6).

The slice remains deliberately limited to declared-domain ingestion and model-scoped propagation. No configuration expansion/search strategy is enabled; bounded_generation_parameter_ranges remains empty and Fixed remains the only executable strategy.

Integration remains blocked: keep this PR draft / DO NOT MERGE until VALUE-02D #132 is REAL_ENVIRONMENT PASS and VALUE-02 acceptance is formally closed. This evidence is software semantics only and makes no real model/device/performance claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant