feat(tui): the surface uses its own palette, not the terminal's theme (#455) - #492
Merged
Conversation
…#455) The reviewed design specifies colours. The build was emitting ANSI names — `"cyan"`, `"green"`, `"yellow"` — which hand the decision to whoever themed the terminal, so the same binary looked different on every machine and matched the agreed design on none of them. On a theme where "yellow" sits close to the body text, the line warning that a live run cannot find its keys was barely distinguishable from the text around it. Now one `PALETTE` with the tokens from the artifact: accent `#93a2ff` for selection, `#7dc9a0` for alive-and-well, `#d9a441` for wants-attention, `#e0796b` for failed. Verified from the built binary: with a truecolor terminal it emits `38;2;147;162;255` — the exact hex — and chalk downsamples to the nearest 256 (`38;5;147`) where it cannot, so the worst case is what we had before rather than a broken screen. Colour is never the only carrier: every state that has one also has a glyph or a word, so `NO_COLOR`, a pipe, and a 16-colour terminal all still say what is happening. release:check green under CI=true (1597 root, 44 tui, bundle smoke, surface scan).
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(tui): the surface uses its own palette, not the terminal's theme (#455)
The reviewed design specifies colours. The build was emitting ANSI names
—
"cyan","green","yellow"— which hand the decision to whoeverthemed the terminal, so the same binary looked different on every machine
and matched the agreed design on none of them. On a theme where "yellow"
sits close to the body text, the line warning that a live run cannot find
its keys was barely distinguishable from the text around it.
Now one
PALETTEwith the tokens from the artifact: accent#93a2ffforselection,
#7dc9a0for alive-and-well,#d9a441for wants-attention,#e0796bfor failed. Verified from the built binary: with a truecolorterminal it emits
38;2;147;162;255— the exact hex — and chalkdownsamples to the nearest 256 (
38;5;147) where it cannot, so the worstcase is what we had before rather than a broken screen.
Colour is never the only carrier: every state that has one also has a
glyph or a word, so
NO_COLOR, a pipe, and a 16-colour terminal allstill say what is happening.
release:check green under CI=true (1597 root, 44 tui, bundle smoke,
surface scan).