release: 0.53.0 — it looks like the design now - #493
Merged
Conversation
The surface was emitting ANSI colour names, so the terminal's theme decided what the reviewed design looked like. It now carries its own palette — accent `#93a2ff`, alive `#7dc9a0`, attention `#d9a441`, failed `#e0796b` — and emits the exact hex on a truecolor terminal, downsampling to the nearest 256 where it cannot. Colour is never the only carrier: every state that has one also has a glyph or a word, so NO_COLOR, a pipe and a 16-colour terminal all still say what is happening.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
CI failed one golden on Node 24 that passed on Node 22 and locally, which is the signature of a timing-dependent assertion rather than a real difference. The cause: the spinner glyph is part of every live frame and advances on a 120ms timer, so any golden containing one depended on which phase the scheduler happened to be in when the frame was captured. There are four such goldens, and they would have failed intermittently forever. `App` now takes a `tick` override for the same reason it takes `now`, and every render in the suite freezes both. Ran the suite three times over after the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release: 0.53.0 — it looks like the design now
The surface was emitting ANSI colour names, so the terminal's theme
decided what the reviewed design looked like. It now carries its own
palette — accent
#93a2ff, alive#7dc9a0, attention#d9a441, failed#e0796b— and emits the exact hex on a truecolor terminal, downsamplingto the nearest 256 where it cannot.
Colour is never the only carrier: every state that has one also has a
glyph or a word, so NO_COLOR, a pipe and a 16-colour terminal all still
say what is happening.