Skip to content

fixed bug in moddump_flyby where secondary's orbit was not being set properly #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieljprice merged 2 commits into from
Jul 17, 2026
+13 −1
Merged

fixed bug in moddump_flyby where secondary's orbit was not being set properly #852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ebe66
fixed bug where secondary's orbit was not being set properly
ahermosillo Jul 10, 2026
43d8832
added small changes recommended by gemini code assist
ahermosillo Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/utils/moddump_addflyby.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,27 @@ subroutine modify_dump(npart,npartoftype,massoftype,xyzh,vxyzu)

if (ierr /= 0) stop 'run phantommoddump again with new .moddump file'

xyzmh_ptmass_in = 0.
vxyz_ptmass_in = 0.
nptmass_in = 0
call set_orbit(orbit,m1,m2,hacc1,accr2,xyzmh_ptmass_in,vxyz_ptmass_in,&
nptmass_in,(id==master),ierr)
Comment thread
ahermosillo marked this conversation as resolved.

nptmass = nptmass + 1
if (nptmass > size(xyzmh_ptmass, 2)) then
call fatal('moddump', 'Not enough space in xyzmh_ptmass for another sink particle')
endif

! translate the secondary so that it is correctly set relative to the primary
xyzmh_ptmass(:,nptmass) = xyzmh_ptmass_in(:,2)
vxyz_ptmass(:,nptmass) = vxyz_ptmass_in(:,2)

xyzmh_ptmass(1:3,nptmass) = xyzmh_ptmass(1:3,nptmass) &
+ xyzmh_ptmass(1:3,1) &
- xyzmh_ptmass_in(1:3,1)

vxyz_ptmass(:,nptmass) = vxyz_ptmass_in(:,2) &
+ vxyz_ptmass(:,1) &
- vxyz_ptmass_in(:,1)

call reset_centreofmass(npart,xyzh,vxyzu,nptmass,xyzmh_ptmass,vxyz_ptmass)

Expand Down
Loading