Skip to content

(build) compile without warnings with gfortran v16#127

Merged
danieljprice merged 2 commits into
mainfrom
trajectory-files
Jun 24, 2026
Merged

(build) compile without warnings with gfortran v16#127
danieljprice merged 2 commits into
mainfrom
trajectory-files

Conversation

@danieljprice

@danieljprice danieljprice commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of longer text labels during grid conversion to prevent unintended truncation.
    • Enhanced label text processing to accept a wider range of string lengths consistently.
    • Updated integration unit-label handling to avoid fixed-length limits, preserving full label text in the output.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 31ff4603-8a17-4146-b886-822680080a51

📥 Commits

Reviewing files that changed from the base of the PR and between f1ff45d and d4b16f6.

📒 Files selected for processing (1)
  • src/labels.f90

📝 Walkthrough

Walkthrough

Three helper routines now accept assumed-length character dummy arguments instead of fixed-length declarations.

Changes

Assumed-length character dummy arguments

Layer / File(s) Summary
Assumed-length character dummy args in three helpers
src/labels.f90, src/convert_grid.f90, src/read_data_dragon.f90
strip_units, shortstring, and shortlabel now take assumed-length character arguments; get_splash2grid_options and find_weights also switch their character dummy arguments to len=*.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hopped through strings so neat,
Letting lengths be free and complete.
No padding, no trim,
Just len=* and a grin —
Now labels fit perfectly sweet.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adjusting Fortran character argument lengths to eliminate gfortran v16 warnings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch trajectory-files

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several character dummy arguments to use assumed-length (character(len=*)) instead of fixed lengths across convert_grid.f90, labels.f90, and read_data_dragon.f90. However, in src/labels.f90, changing string to assumed-length in shortlabel introduces a potential Fortran standard violation when it is passed to shortstring (which still expects a fixed length of lenlabel). This can cause undefined behavior if a shorter string is passed, and it is recommended to either update shortstring to assumed-length as well or use a local variable to copy the string.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/labels.f90
@danieljprice
danieljprice merged commit 4efd030 into main Jun 24, 2026
6 checks passed
@danieljprice
danieljprice deleted the trajectory-files branch June 24, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant