Add audit documentation and CI lint workflow#7
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $results = Invoke-ScriptAnalyzer -Path ./PSToolkit.ps1 -Recurse | ||
| if ($results) { | ||
| Write-Host "PSScriptAnalyzer findings:" -ForegroundColor Yellow | ||
| $results | Format-Table -AutoSize |
There was a problem hiding this comment.
Fail lint job when ScriptAnalyzer reports violations
The lint workflow captures Invoke-ScriptAnalyzer output and prints it, but the step never sets a failing exit code when $results contains findings. As written, pull requests with lint errors will still pass CI because the job always exits successfully after the Write-Host calls. Consider returning a non‑zero exit (e.g., if ($results) { $results | Format-Table; exit 1 }) so lint violations actually block merges.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f356d6591c8332b97934887f4212e6