Skip to content

Add audit documentation and CI lint workflow#7

Merged
danielpmadden merged 1 commit into
mainfrom
codex/audit-and-modernize-repository-for-compliance
Oct 18, 2025
Merged

Add audit documentation and CI lint workflow#7
danielpmadden merged 1 commit into
mainfrom
codex/audit-and-modernize-repository-for-compliance

Conversation

@danielpmadden

Copy link
Copy Markdown
Owner

Summary

  • refresh the README to match the current PowerShell script capabilities and point to new dependency documentation
  • add ROADMAP and CHANGELOG files plus a tests directory placeholder to guide future contributions
  • create a lint-focused GitHub Actions workflow and repository .gitignore for generated artifacts

Testing

  • not run (documentation and automation scaffolding only)

https://chatgpt.com/codex/tasks/task_e_68f356d6591c8332b97934887f4212e6

@danielpmadden danielpmadden merged commit e872c10 into main Oct 18, 2025
1 check passed
@danielpmadden danielpmadden deleted the codex/audit-and-modernize-repository-for-compliance branch October 18, 2025 09:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +27 to +30
$results = Invoke-ScriptAnalyzer -Path ./PSToolkit.ps1 -Recurse
if ($results) {
Write-Host "PSScriptAnalyzer findings:" -ForegroundColor Yellow
$results | Format-Table -AutoSize

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fail lint job when ScriptAnalyzer reports violations

The lint workflow captures Invoke-ScriptAnalyzer output and prints it, but the step never sets a failing exit code when $results contains findings. As written, pull requests with lint errors will still pass CI because the job always exits successfully after the Write-Host calls. Consider returning a non‑zero exit (e.g., if ($results) { $results | Format-Table; exit 1 }) so lint violations actually block merges.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant