feat: Add payment history command to CLI and update bill history description - #21
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new CLI command to fetch combined bill+payment history, and updates user-facing docs to clearly distinguish “bill history” (bills issued) from “payment history” (bills and payments).
Changes:
- Added
payment-historyCLI command that callsget_payment_history()and renders a combined history table (with JSON output support). - Updated
bill-historyCLI description/help to clarify it returns bills issued (not payments). - Updated
README.mdCLI examples and documented data models to include the new history entry types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mytnb/cli.py | Adds payment-history command and clarifies bill-history help text. |
| README.md | Updates examples/CLI usage text and expands the documented data models for the new response types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
payment-historyCLI command, clarifies the distinction between bill and payment history in both the CLI and documentation, and updates the data model documentation to include new types. These changes improve clarity for users and provide access to more detailed billing and payment information.CLI Improvements
payment-historycommand to the CLI, which retrieves and displays both bill and payment history for a given account, with support for JSON output.bill-historycommand and its help text to clarify that it only returns bills issued, not payments.Documentation Updates
README.mdto clarify the difference betweenbill-history(bills issued) andpayment-history(bills and payments), and to reflect the new command.README.mdto show how to fetch both bill and payment history, and added a note about passingCustomerAccountobjects to methods.Data Model Documentation
BillHistoryEntry,PaymentHistoryEntry, andAccountDueAmountto the documented data models inREADME.mdto reflect new response types.