Add schemars v1 support - #109
Merged
Merged
Conversation
danlehmann
approved these changes
Jul 27, 2026
Owner
|
Thanks for the contribution. Looks great and happy to take it, but it currently fails tests (test step). |
Contributor
Author
The test failure is unrelated to this PR. See #112 |
# Conflicts: # CHANGELOG.md
Owner
|
Fixed the two test failures on main. merged them over. landing the PR now. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
schemarsv1 support via a newschemars1feature. Since v1 is a breaking release with an incompatible API, it's exposed separately and the v1 dep is aliased so it coexists with the existing v0.8schemarsfeature.JsonSchemais implemented forUInt/Intthrough the preexistingimpl_schemars!macro.Following
schemars' own handling of primitive integers,minimum/maximumare only emitted for integers smaller than 32 bits (see added code comment and GREsau/schemars#298).AI disclosure: the implementation and tests were written by me. Claude Code assisted with fixing grammar in code comment, adding changelog and drafting this PR.