Skip to content

Style privacy policy #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmooney merged 1 commit into from
May 13, 2026
Merged

Style privacy policy #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ <h3>Common Use Cases</h3>
<li><a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON" target="_blank" rel="noopener">MDN Web Docs - JSON</a></li>
</ul>
<p class="affiliate-disclosure"><small>As an Amazon Associate, we earn from qualifying purchases. This site may contain affiliate links; we may earn a commission at no extra cost to you.</small></p>
<p><small><a href="/privacy.html">Privacy Policy</a></small></p>
<p><small><a href="/privacy">Privacy Policy</a></small></p>
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check what privacy page file exists in the repo and where /privacy is referenced.
fd -a 'privacy(\.html|/index\.html)$' public
rg -n 'href="/privacy"' public/index.html public/privacy.html

Repository: danmooney/dict2json

Length of output: 191

🏁 Script executed:

# Check for web server configuration files
find . -type f \( -name ".htaccess" -o -name "nginx.conf" -o -name "*.config.js" -o -name "vercel.json" -o -name ".netlify" -o -name "next.config.js" \) 2>/dev/null

Repository: danmooney/dict2json

Length of output: 106

🏁 Script executed:

# Check for other href patterns in index.html to see the general pattern used
rg -n 'href="/' public/index.html | head -20

Repository: danmooney/dict2json

Length of output: 199

🏁 Script executed:

# Check project type and main dependencies to understand deployment model
cat package.json 2>/dev/null | head -30

Repository: danmooney/dict2json

Length of output: 776

🏁 Script executed:

# Check for any README or deployment documentation
fd -i readme public . -x head -50 {} \;

Repository: danmooney/dict2json

Length of output: 45

🏁 Script executed:

cat webpack.config.js

Repository: danmooney/dict2json

Length of output: 907

🏁 Script executed:

# Check if privacy.html is referenced in the build process or if there's any routing/rewrite configuration
rg -n 'privacy' webpack.config.js

Repository: danmooney/dict2json

Length of output: 45

🏁 Script executed:

# Check the actual public directory structure to see what gets deployed
ls -la public/

Repository: danmooney/dict2json

Length of output: 473

Change /privacy link to /privacy.html or add server rewriting.

The link will 404 in the dev server and likely on most deployment platforms without URL rewriting configured. The actual file is privacy.html, but the href points to /privacy with no extension. The webpack configuration has no rewrite rules (no historyApiFallback or URL rewrites configured), and the static file serving in the dev server will not automatically resolve extensionless paths.

Either update the link to href="/privacy.html" or configure server rewriting rules to map /privacy to privacy.html.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@public/index.html` at line 94, Update the anchor href that currently points
to "/privacy" so it targets the actual static file (change the <a
href="/privacy"> link in public/index.html to "/privacy.html") or alternatively
add server-side/static dev-server rewrite rules to map the path "/privacy" to
"privacy.html" (modify the anchor in index.html or configure your dev server's
rewrite/history fallback accordingly).

Copy link
Copy Markdown
Owner Author

@danmooney danmooney May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works fine

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmooney, thanks for confirming! I'll note that the /privacy route resolves correctly in your deployment setup so this isn't flagged again in future reviews.

✏️ Learnings added 
Learnt from: danmooney
Repo: danmooney/dict2json PR: 4
File: public/index.html:94-94
Timestamp: 2026-05-13T14:44:09.330Z
Learning: In the `danmooney/dict2json` repository, the `/privacy` (extensionless) URL route works correctly and resolves to `public/privacy.html`. The server or deployment platform handles the extensionless URL rewriting automatically. Do not flag `/privacy` href links as potentially broken in this project.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

</footer>
<!-- Google tag (gtag.js) -->
<script async src="https://www.googletagmanager.com/gtag/js?id=G-QFE6TJB3X9"></script>
Expand Down
63 changes: 63 additions & 0 deletions public/privacy.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,69 @@
<title>Privacy Policy - Python Dict to JSON Converter</title>
<meta name="description" content="Privacy policy for dict2json.com, the Python dictionary to JSON converter.">
<link rel="icon" type="image/svg+xml" href="/favicon.svg">
<style>
:root {
--font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
--tooltip-bg: #2d3748;
}

body {
margin: 0;
font-family: var(--font-family);
}

.content-section {
max-width: 80%;
margin: 0 auto;
padding: 20px;
font-family: var(--font-family);
}

.content-section h1 {
color: var(--tooltip-bg);
margin: 0 0 24px;
font-size: 32px;
}

.content-section h2 {
color: var(--tooltip-bg);
margin: 40px 0 20px;
font-size: 24px;
}

.content-section p {
line-height: 1.6;
color: #4a5568;
margin: 15px 0;
}

.content-section ul {
margin: 15px 0;
padding-left: 20px;
}

.content-section li {
line-height: 1.6;
margin: 8px 0;
color: #4a5568;
}

.content-section a {
color: #2563eb;
text-decoration: none;
}

.content-section a:hover {
text-decoration: underline;
}

@media (max-width: 600px) {
.content-section {
max-width: 95%;
padding: 10px;
}
}
</style>
</head>
<body>
<main class="content-section">
Expand Down
2 changes: 1 addition & 1 deletion src/styles/layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ footer li {
max-width: 95%;
padding: 10px;
}

.content-section table {
display: block;
overflow-x: auto;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/variables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
--success-bg: #059669;
--success-text: #ffffff;
--highlight-line: #e3f2fd;
}
}
Loading