Skip to content

Pin Node version via .nvmrc#6

Merged
danmooney merged 1 commit into
mainfrom
develop
May 20, 2026
Merged

Pin Node version via .nvmrc#6
danmooney merged 1 commit into
mainfrom
develop

Conversation

@danmooney
Copy link
Copy Markdown
Owner

@danmooney danmooney commented May 20, 2026

Aligns local and CI Node versions by sourcing from .nvmrc instead of hard-coding in workflows. Adds package.json engines for tooling that reads it.

Summary by CodeRabbit

  • Chores
    • Node.js version requirement updated to 22+.
    • Build and deployment workflows updated to use the latest Node.js setup tooling.
    • Project now requires Node.js 22+ for local development, testing, and deployment.
    • Version configuration centralized for consistency across all build environments.
    • Ensures uniform runtime environment across development and production pipeline stages.

Review Change Stack

Aligns local and CI Node versions by sourcing from .nvmrc instead of
hard-coding in workflows. Adds package.json engines for tooling that
reads it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cd306487-2386-4a3b-9e1a-8827d507b349

📥 Commits

Reviewing files that changed from the base of the PR and between e8f5f8b and 89887b1.

📒 Files selected for processing (4)
  • .github/workflows/deploy.yml
  • .github/workflows/tests.yml
  • .nvmrc
  • package.json

📝 Walkthrough

Walkthrough

This PR centralizes Node.js version management by introducing .nvmrc as a single source of truth. Both CI workflows now read the version from .nvmrc via the newer actions/setup-node@v4, replacing hardcoded version pins. Package.json declares the engine requirement to match.

Changes

Centralize Node.js Version Management

Layer / File(s) Summary
Node.js version sources
.nvmrc, package.json
.nvmrc specifies the runtime version, and package.json declares an engines.node constraint of >=22.
Workflow Node.js setup updates
.github/workflows/deploy.yml, .github/workflows/tests.yml
Both deploy and tests workflows upgrade from actions/setup-node@v3 with hardcoded node-version: '22' to actions/setup-node@v4 with node-version-file: '.nvmrc'.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A single source of truth does appear,
No version pinned elsewhere to fear!
From .nvmrc it flows so clean,
Through workflows both—a unified scene.
Now package and actions align at last,
Building Node.js futures, not stuck in the past!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Pin Node version via .nvmrc' accurately summarizes the main objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands and usage tips.

@danmooney danmooney merged commit f86577c into main May 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant