Conversation
Chrome on iOS doesn't render SVG favicons, so the tab icon was blank for that audience. Ship 16/32 PNGs, a 180px apple-touch-icon, and a multi-size .ico so non-SVG-capable browsers have something to fall back to. The SVG stays primary for browsers that support it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR ensures favicon assets are properly tracked and referenced: ChangesFavicon Assets and References
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome on iOS doesn't render SVG favicons, so the tab icon was blank for that audience. Ship 16/32 PNGs, a 180px apple-touch-icon, and a multi-size .ico so non-SVG-capable browsers have something to fall back to. The SVG stays primary for browsers that support it.
Summary by CodeRabbit