fix: strip server env vars (PORT, AUTH_TOKEN, etc.) from child#104
fix: strip server env vars (PORT, AUTH_TOKEN, etc.) from child#104gfbonny wants to merge 7 commits intodanshapiro:mainfrom
Conversation
…ocesses Child terminals inherited Freshell's PORT, VITE_PORT, AUTH_TOKEN, and ALLOWED_ORIGINS, causing port conflicts when running other dev servers inside Freshell and leaking credentials into child processes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Refresh directory structure, add testing/linting command docs, and update architectural descriptions to reflect current codebase layout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a02f376fb3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| npx vitest run -t "handles resize" | ||
| ``` | ||
|
|
||
| There are **two vitest configs**: `vitest.config.ts` (client, jsdom environment) and `vitest.server.config.ts` (server, node environment). Client tests live in `test/unit/client/`, `test/integration/client/`, and `test/e2e/`. Server tests live in `test/server/`, `test/unit/server/`, and `test/integration/server/`. The default `npm test` runs the client config; `npm run test:all` runs both. |
There was a problem hiding this comment.
The new testing note says the default npm test only runs the client Vitest config, but package.json defines test as vitest run && vitest run --config vitest.server.config.ts, so it runs both client and server suites. This mismatch can cause contributors to under-test server changes if they follow AGENTS literally, letting server regressions slip through despite believing they ran the default test workflow.
Useful? React with 👍 / 👎.
Resolves conflict in buildSpawnSpec(): keeps both our server-specific env var stripping (PORT, VITE_PORT, AUTH_TOKEN, ALLOWED_ORIGINS) and upstream's NODE_ENV/npm_lifecycle_script stripping. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: FreshClaude textarea focus loss from Pane role and autoFocus timing
1 participant
No description provided.