Skip to content

Add native PowerShell runner for Fresh Eyes on Windows#1

Open
danshapiro wants to merge 1 commit intomainfrom
feat/windows-powershell-runner
Open

Add native PowerShell runner for Fresh Eyes on Windows#1
danshapiro wants to merge 1 commit intomainfrom
feat/windows-powershell-runner

Conversation

@danshapiro
Copy link
Owner

Summary\n- add native PowerShell runner: skills/fresheyes/fresheyes.ps1\n- add PowerShell progress helper: skills/fresheyes/fresheyes-progress.ps1\n- update README.md with Windows runner entrypoint and usage example\n- update skills/fresheyes/SKILL.md Step 4 to include PowerShell invocation\n\n## Why\nFresh Eyes currently depends on Bash + python3 shell behavior, which is brittle on Windows PowerShell shells. This PR provides a first-class PowerShell path while keeping existing shell scripts intact.\n\n## Validation\n- powershell -ExecutionPolicy Bypass -File skills/fresheyes/fresheyes.ps1 --help\n- powershell -ExecutionPolicy Bypass -File skills/fresheyes/fresheyes.ps1 --provider nope (expected provider validation error)\n- powershell -ExecutionPolicy Bypass -File skills/fresheyes/fresheyes.ps1 --mode invalid (expected mode validation error)\n- powershell -ExecutionPolicy Bypass -File skills/fresheyes/fresheyes-progress.ps1\n\n## Notes\n- no changes were made to wsl-fresheyes mirror repo\n- existing resheyes.sh behavior remains unchanged

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ace44bae37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +271 to +272
$result = Invoke-CommandCapture -Exe "codex" -Arguments $argsList
$result.output | Tee-Object -FilePath $logFile | Out-Null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stream reviewer output while command is running

This writes to the log only after codex exits because output is first captured in $result and then piped to Tee-Object. For long reviews, that means fresheyes-progress.ps1 cannot show growing line counts during execution (it appears stalled), and the full response is buffered in memory instead of streamed. The Bash runner streams with | tee, so this is a Windows regression in the new PowerShell path.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant