Fix Storybook model cache mocks#493
Merged
Merged
Conversation
Co-authored-by: cooper <czxtm@users.noreply.github.com>
8 tasks
cooper (czxtm)
marked this pull request as ready for review
July 7, 2026 03:57
Juanpe Bolívar (arximboldi)
approved these changes
Jul 13, 2026
Juanpe Bolívar (arximboldi)
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models.setCached,models.getCached, andmodels.clearCached.Reproduction / verification steps
Regression being verified: provider selectors can call the Storybook model-cache oRPC mock methods used by the app.
cd apps/native bun run test:unit src/storybook-tauri-runtime.test.tsExpected result: the test passes and covers
models.setCached,models.getCached, andmodels.clearCachedin the Storybook Tauri runtime mock.Manual Storybook check, if desired:
cd apps/native && bun run storybook.models.*CachedoRPC handler error is thrown in the browser console.Test Plan
cd apps/native && bun run test:unit src/storybook-tauri-runtime.test.tsDocs