Skip to content

fix(onboarding): accept CLI providers without a model#503

Merged
Alex Shabalin (alex-sparus) merged 1 commit into
mainfrom
alex/fixonboarding-accept-cli-providers-without-a-model
Jul 10, 2026
Merged

fix(onboarding): accept CLI providers without a model#503
Alex Shabalin (alex-sparus) merged 1 commit into
mainfrom
alex/fixonboarding-accept-cli-providers-without-a-model

Conversation

@alex-sparus

Copy link
Copy Markdown
Contributor

Empty model means "use the CLI default" for claude/codex/opencode, but step readiness required a non-empty evolveModel, so saving a CLI provider silently kept the flow on the inference step.

Summary

Onboarding was stuck if Codex CLI was selected without a model name (which means "use default", as the UI displayed)

Test Plan

  • Onboarding passes with Codex CLI and empty model name

Docs

  • Docs updated (companion PR in darkmatter/nixmac-web: #___)
  • No docs update needed

Empty model means "use the CLI default" for claude/codex/opencode,
but step readiness required a non-empty evolveModel, so saving a CLI
provider silently kept the flow on the inference step.
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

No Linear issue ID found in this PR's title, description, or branch name (expected something like ENG-123). Add one so this work is traceable in Linear, or add #no-linear to the PR description to acknowledge it's intentionally untracked.

📋 PR Overview

Lines changed 47 (+44 / -3)
Files 0 added, 5 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
Linear issue no
No Test Plan Needed no
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 34.3% 33.9% 30.5% 28.6%

Generated by 🚫 dangerJS against 913b089

@alex-sparus

Copy link
Copy Markdown
Contributor Author

I'll fix the actual issues with Codex CLI in a different PR

2026-07-08T13:41:20.345492Z  INFO nixmac::rebuild::darwin: [darwin] Logging to: "/Users/alex/Library/Logs/
nixmac/darwin-rebuild_2026-07-08_15-41-20.log"
2026-07-08T13:41:20.963441Z  WARN nixmac::ai::log_summarizer: [log_summarizer] Summarization failed: 'code
x' exited with exit status: 2: error: unexpected argument '--quiet' found

  tip: to pass '--quiet' as a value, use '-- --quiet'

Usage: codex [OPTIONS] [PROMPT]
       codex [OPTIONS] <COMMAND> [ARGS]

For more information, try '--help'.
2026-07-08T13:41:21.523701Z  WARN nixmac::ai::log_summarizer: [log_summarizer] Summarization failed: 'code

@darkmatter

darkmatter Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🎨 Storybook preview

Open Storybook preview

Updated for 913b089


⚠️ Detected UI changes (5)

These stories' HTML snapshots changed. I've added screenshots + links to the changed stories below. Review them carefully then accept the changes to regenerate baselines and include them in this PR:

Widget/Controls/FlakeDirChooser › Multiple Candidates

Widget/Controls/FlakeDirChooser › Multiple Candidates

Widget/Controls/FlakeDirChooser › Applying

Widget/Controls/FlakeDirChooser › Applying

Widget/Drift/DriftReview › Unsummarized

Widget/Drift/DriftReview › Unsummarized

Widget/Drift/DriftReview › Summarized

Widget/Drift/DriftReview › Summarized

Widget/Drift/DriftReview › Ai Session

Widget/Drift/DriftReview › Ai Session


Accept UI changes

  • Click here to accept these changes

Alternatively, you can run bun run test:update-snapshots locally to re-generate the baselines and then push the changes to this PR.

What does this do?

The screenshots above show UI changes detected by the Storybook
snapshot tests run on this PR. Each image is the rendered output of
a Storybook story from the code in this PR branch; the snapshot
test compared it against the committed baseline in
__snapshots__/ and flagged the difference.

Checking the box tells the darkmatter[bot] to regenerate the
baselines from this PR's current code and commit them directly to
this branch. The new baselines become the source of truth for
future runs — only accept after confirming the visual changes are
intentional.

Comparison baseline: the committed __snapshots__/ files on this
PR branch (carried forward from develop). Accept updates them in
place on this branch.

@arximboldi Juanpe Bolívar (arximboldi) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congrats on your first PR :) LGTM

@alex-sparus

Copy link
Copy Markdown
Contributor Author

I think it's almost a duplicate of #492
I'll continue working on the CLI providers because it's really buggy right now 😅

@alex-sparus
Alex Shabalin (alex-sparus) added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit 2616dcc Jul 10, 2026
10 checks passed
@alex-sparus
Alex Shabalin (alex-sparus) deleted the alex/fixonboarding-accept-cli-providers-without-a-model branch July 10, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants