fix: add lenis-svelte to the list of plugins#374
Closed
DaniAcu wants to merge 1 commit intodarkroomengineering:mainfrom
Closed
fix: add lenis-svelte to the list of plugins#374DaniAcu wants to merge 1 commit intodarkroomengineering:mainfrom
DaniAcu wants to merge 1 commit intodarkroomengineering:mainfrom
Conversation
|
@DaniAcu is attempting to deploy a commit to the darkroom Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks @DaniAcu, what do you think about working on |
Contributor
Author
|
@clementroche do you mean inside this package? It will be great, I could create another PR to move the lib here. I have a couple questions,
|
Member
|
Contributor
Author
|
Okay, I will move the package here. Do you want to have any other framework wrapper? |
Member
|
vue |
|
Hello, I have created a Svelte5 binding as a preview for future versions. https://github.com/richhost/svelte-lenis |
Contributor
Author
|
Sorry for the delay @clementroche I will close this PR in favor of this #390. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm started working on svelte, and I notice lenis doesn't have a wrapper for svelte like it does for nuxt and vue. So I create the package.
If you are okay with adding this package here it will be really helpful for future svelte developer that are trying to use this awesome library in their projects.