fix: respect scroll-margin and scroll-padding in scrollTo#507
Open
clementroche wants to merge 4 commits intomainfrom
Open
fix: respect scroll-margin and scroll-padding in scrollTo#507clementroche wants to merge 4 commits intomainfrom
clementroche wants to merge 4 commits intomainfrom
Conversation
This was referenced Mar 18, 2026
feledori
approved these changes
Mar 18, 2026
Contributor
feledori
left a comment
There was a problem hiding this comment.
reading from scrollmargins and paddings should not trigger reflows so this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scroll-marginon target elements andscroll-paddingon the scroll container when calculating scroll positions inscrollTo()Element.scrollIntoView()getComputedStyle()only when scrolling to a DOM element (no perf impact on coordinate-based scrolls)Fixes #503
Fixes #196
Test plan
scroll-marginexamplescroll-marginland at the correct offsetscroll-paddingare respectedscrollTo()with numeric targets